Upgrade Hamcrest to 3.0 #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If upstream changelogs are to be believed, there are no breaking changes except for: * The packaging method being changed[1] from several JARs to one JAR. * An annotation, `org.hamcrest.Factory`, being removed (we don't use it, and upstream says that people should not have been using it externally) * The minimum version being upgraded to Java 8[2], which is already the case in Ant. [1]: https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1 [2]: https://github.com/hamcrest/JavaHamcrest/releases/tag/v3.0
tomodachi94
force-pushed
the
chore/hamcrest-3.0-upgrade
branch
from
a6c1751 to
9905daf
Compare
|
Things seem to work with Hamcrest 3, thank you. Actually the hamcrest jars are checked in into the repository (something that look strange for people today, I know :-), so you need to remove the 1.x jars and add the 3.0 one. And https://github.com/apache/ant/blob/master/lib/optional/LICENSE.hamcrest.txt should be adjusted as well. |
|
Pushed both changes as new commits onto this PR's branch. Let me know if you prefer everything to be squashed into one commit. |
|
thank you Do you want to be credited inside our CONTRIBUTORS file - and if yes, by which name? |
|
Sure, that would be cool ❤️ I'm going to take a look at the issue tracker to see if there's anything there that I can help with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If upstream changelogs are to be believed, there are no breaking changes except for:
org.hamcrest.Factory, being removed (we don't use it, and upstream says that people should not have been using it externally)